[
https://issues.apache.org/jira/browse/HDDS-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740027#comment-16740027
]
Xiaoyu Yao commented on HDDS-943:
---------------------------------
Thanks [~ajayydv] for woking on this. The patch v2 looks good to me. Here are a
few minor comments:
ContainerStateMachine.java
Line 302: can we add some log here or in the BlockTokenVerifier#verify? We will
also need to audit log as well, which may be handled in a follow up jira.
HddsConfigKeys.java
Line 130: we need to update ozone-default.xml to reflect the config key change.
OzoneManager.java
Line 332: Unnecessary change. We are trying to minimize usage of guava
predondition check and replace it with jdk8/9 Objects.checkNotNull()
SCMSecurityException.java
Line 50: NIT: javadoc needs to be udpated.
TestContainerStateMachine.java
Line 66: NIT: unused var
Line 129-133: NIT: unused var
TestSecureContainerServer.java
Line 153: NIT: unused var
> Changes in HddsDispatcher/XceiverServer to handle block token validation
> ------------------------------------------------------------------------
>
> Key: HDDS-943
> URL: https://issues.apache.org/jira/browse/HDDS-943
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-943-HDDS-4.00.patch, HDDS-943-HDDS-4.01.patch
>
>
> [HDDS-805] embeds an encoded token in {{ContainerCommandRequestProto}}. This
> token should be validated at HddsDispatcher or XceiverServer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
