[
https://issues.apache.org/jira/browse/HDFS-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740093#comment-16740093
]
venkata ramkumar edited comment on HDFS-14197 at 1/11/19 6:48 AM:
------------------------------------------------------------------
Thanks [~ayushtkn] for the comment.
{quote}HDFS-8402 seems to be dealing with the exit code issue with FSCK
{quote}
Please check the comments in HDFS-8402
{quote}Prior to blockId checking, ie. path based scans, fsck determined exit
code based on whether the last line contained HEALTHY or CORRUPT. This doesn't
make sense when displaying multiple blocks with multiple storages. Modified
NN's blockid scans to return a final line similar to path-based scans. Removed
the recent logic that flagged nodes with decom nodes as an error.
{quote}
{quote}The real motivation for this patch is to use {{bm.getStorages(block)}}
instead of directly accessing the storages. This altered the order of the
storages, which broke the tests. The tests were specifically coded (grumble) to
ensure the last displayed storage was in the state expected by the test.
{quote}
Please let me know how its related to HDFS-8402.
was (Author: ramkumar):
Thanks [~ayushtkn] for the comment.
{quote}HDFS-8402 seems to be dealing with the exit code issue with FSCK
{quote}
Please check the comments in HDFS-8402
{quote}Prior to blockId checking, ie. path based scans, fsck determined exit
code based on whether the last line contained HEALTHY or CORRUPT. This doesn't
make sense when displaying multiple blocks with multiple storages. Modified
NN's blockid scans to return a final line similar to path-based scans. Removed
the recent logic that flagged nodes with decom nodes as an error.
{quote}
bq. The real motivation for this patch is to use {{bm.getStorages(block)}}
instead of directly accessing the storages. This altered the order of the
storages, which broke the tests. The tests were specifically coded (grumble) to
ensure the last displayed storage was in the state expected by the test.
Please let me know how its related to the jira HDFS-8402.
> Invalid exit codes for invalid fsck report
> -------------------------------------------
>
> Key: HDFS-14197
> URL: https://issues.apache.org/jira/browse/HDFS-14197
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.1.1
> Reporter: Harshakiran Reddy
> Assignee: venkata ramkumar
> Priority: Minor
>
> {noformat}
> bin> ./hdfs fsck /harsha/file1 -blocks -files -locations
> FileSystem is inaccessible due to:
> java.io.FileNotFoundException: File does not exist: /harsha/file1
> DFSck exiting.
> bin> echo $?
> 0
> bin>
> {noformat}
> Excepted Result :
> It should be 1
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
