[
https://issues.apache.org/jira/browse/HDFS-14195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740217#comment-16740217
]
Adam Antal commented on HDFS-14195:
-----------------------------------
Hi [~suxingfate]. Thanks for the issue and the patch. Don't forget to assign
this issue to yourself.
The patch is good, some minor things that I noticed:
- In the function {{getEntry()}} of symlink type in
{{PBImageDelimitedTextWriter.java}} the fields are not in the same order as in
the file's and folder's case (storage policy, ns quota, ds quota).
- Don't forget to address the test failures related to the OIV tool. The tests
are now should expect the extra field. Also a new test case with some given
storage policy, which is not the default (BLOCK_STORAGE_POLICY_ID_UNSPECIFIED)
is recommended to test this field addition.
> OIV: print out storage policy id in oiv Delimited output
> --------------------------------------------------------
>
> Key: HDFS-14195
> URL: https://issues.apache.org/jira/browse/HDFS-14195
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: tools
> Reporter: Wang, Xinglong
> Priority: Minor
> Attachments: HDFS-14195.001.patch
>
>
> There is lacking of a method to get all folders and files with sort of
> specified storage policy via command line, like ALL_SSD type.
> By adding storage policy id to oiv output, it will help with oiv
> post-analysis to have a overview of all folders/files with specified storage
> policy and to apply internal regulation based on this information.
>
> Currently, for PBImageXmlWriter.java, in HDFS-9835 it added function to print
> out xattr which including storage policy already.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
