[
https://issues.apache.org/jira/browse/HDDS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740649#comment-16740649
]
Xiaoyu Yao commented on HDDS-793:
---------------------------------
Thanks [~elek] for working on this. The patch looks good to me overall. I just
have a few minor comments:
Since Volume/Bucket/Key all have these metadata map, can we add a common base
class that support get/set metadata to de-dup the changes? Also, do we want to
support add/remove key/value pair from the metadata map for certain use cases?
BucketArgs.java
Line 60: NIT: missing javadoc
BucketArgs.java
Line 119/123: NIT: missing javadoc
BucketInfo.java
Line 318/322: NIT: missing javadoc
BucketManagerImpl.java
Line 168: should we add the MetadataMap into the bucketInfoBuilder in
setBucketProperty() as well?
DistributedStorageHandler.java
Line 178/265: should we add the volume metadata here if exists?
Line 399: should we add the bucket metadata here if exists?
Line 526/552/597: should we add the key metadata here if exists?
OmBucketInfo.java
Line 80: NIT: missing javadoc change
OzoneBucket.java
Line 110: NIT: missing javadoc change
OzoneKey.java
Should we expose the metadata here as well?
RestClient.java
Line 418: should we add bucket metadata if exists?
Also, we need to expose get/set bucket metadata.
RpcClient.java
Lien 292: can we expose get/set volume metadata here?
> Support custom key/value annotations on volume/bucket/key
> ---------------------------------------------------------
>
> Key: HDDS-793
> URL: https://issues.apache.org/jira/browse/HDDS-793
> Project: Hadoop Distributed Data Store
> Issue Type: New Feature
> Components: OM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Attachments: HDDS-793.001.patch, HDDS-793.002.patch,
> HDDS-793.003.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I propose to add a custom Map<String,String> annotation field to
> objects/buckets and keys in Ozone Manager.
> It would enable to build any extended functionality on top of the OM's
> generic interface. For example:
> * Support tags in Ozone S3 gateway
> (https://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectGETtagging.html)
> * Support md5 based ETags in s3g
> * Store s3 related authorization data (ACLs, policies) together with the
> parent objects
> As an optional feature (could be implemented later) the client can defined
> the exposed annotations. For example s3g can defined which annotations should
> be read from rocksdb on OM side and sent the the client (s3g)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
