[ 
https://issues.apache.org/jira/browse/HDFS-14202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742052#comment-16742052
 ] 

Ranith Sardar edited comment on HDFS-14202 at 1/14/19 1:17 PM:
---------------------------------------------------------------

In DiskBalancer#copyBlocks method, "timeUsed" is calculated in nanoseconds.
{code:java}
 long begin = System.nanoTime();
this.dataset.moveBlockAcrossVolumes(block, dest);
long now = System.nanoTime();
timeUsed = (now - begin) > 0 ? now - begin : 0;{code}
Then,  timeUsed has been used in computedelay.
{code:java}
 Thread.sleep(computeDelay(block.getNumBytes(), timeUsed, item));{code}
But, Computedelay() is expecting in Milliseconds acc to the code.
{code:java}
 * @param timeUsed    in milliseconds{code}
Need to change milliseconds to nanoseconds. 


was (Author: ranith):
In DiskBalancer#copyBlocks method, "timeUsed" is calculated in nanoseconds.
{code:java}
 long begin = System.nanoTime();
this.dataset.moveBlockAcrossVolumes(block, dest);
long now = System.nanoTime();
timeUsed = (now - begin) > 0 ? now - begin : 0;{code}
Then,  timeUsed has been used in computedelay.
{code:java}
 Thread.sleep(computeDelay(block.getNumBytes(), timeUsed, item));{code}
But, Computedelay() is expecting in Milliseconds acc to the code.
{code:java}
 * @param timeUsed    in milliseconds{code}

> "dfs.disk.balancer.max.disk.throughputInMBperSec" property is not working as 
> per set value.
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-14202
>                 URL: https://issues.apache.org/jira/browse/HDFS-14202
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: diskbalancer
>    Affects Versions: 3.0.1
>            Reporter: Ranith Sardar
>            Assignee: Ranith Sardar
>            Priority: Major
>         Attachments: HDFS-14202.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to