[ 
https://issues.apache.org/jira/browse/HDFS-14206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742692#comment-16742692
 ] 

Yiqun Lin commented on HDFS-14206:
----------------------------------

Thanks [~elgoiri] for the clean-up work! Almost looks good to me, only caught 
one nit:
{code}
+    if (spaceQuota == HdfsConstants.QUOTA_RESET) {
+      ssQuota = StringUtils.byteDesc(spaceQuota);
+      ssCount = StringUtils.byteDesc(getSpaceConsumed());
     }
{code}
{{spaceQuota == HdfsConstants.QUOTA_RESET}} should be {{spaceQuota != 
HdfsConstants.QUOTA_RESET}}

> RBF: Cleanup quota modules
> --------------------------
>
>                 Key: HDFS-14206
>                 URL: https://issues.apache.org/jira/browse/HDFS-14206
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Íñigo Goiri
>            Assignee: Íñigo Goiri
>            Priority: Major
>         Attachments: HDFS-14206-HDFS-13891.000.patch, 
> HDFS-14206-HDFS-13891.001.patch
>
>
> The quota part needs some cleanup.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to