[
https://issues.apache.org/jira/browse/HDDS-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746728#comment-16746728
]
Xiaoyu Yao commented on HDDS-975:
---------------------------------
Thanks [~ajayydv] for the patch. It looks good to me. Just few minor comments:
PrintTokenHandler.java
Line 53: unused variable.
RenewTokenHandler.java
Line 70/71: can we add more context to the print out message for the
expiryTime? The jsonhelper may not add much to a long type.
TestOzoneShell.java
Line 1273: we might need to add some negative case for token file does not
found, invalid token file, etc. for renew and cancel delegation token.
> Manage ozone security tokens with ozone shell cli
> -------------------------------------------------
>
> Key: HDDS-975
> URL: https://issues.apache.org/jira/browse/HDDS-975
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-975-HDDS-4.00.patch, HDDS-975-HDDS-4.01.patch,
> Screen Shot 2019-01-10 at 7.27.21 PM.png
>
>
> Create ozone cli commands for ozone shell
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
