[
https://issues.apache.org/jira/browse/HDFS-13617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16746771#comment-16746771
]
Konstantin Shvachko commented on HDFS-13617:
--------------------------------------------
# {{dfs.namenode.send.qop.enable}} should be {{dfs.namenode.send.qop.enabled}}
# Unused import in {{NameNodeRpcServer}}
# generic type Token<T> should be parameterized
generic type Collection<E> should be parameterized
# {{wrapEstablishedQOP()}} should throw {{IOException}}, rather than
{{RuntimeException}}
# Can we move the logic behind {{wrapEstablishedQOP()}} into
{{BlockTokenSecretManager}}? E.g., you are redefining the constant
{{DFS_QOP_WRAP_HMAC_ALGORITHM}} in NNRPCServer, which is already defined in
{{SecretManager}} a subclass of {{BlockTokenSecretManager}}. Some refactoring
may be good here.
# {{TestBlockTokenWrappingQOP.setup()}} should be {{@BeforeClass}} and
{{tearDown()}} should be {{@AfterClass}} so that we don't start cluster for
every test case.
> Allow wrapping NN QOP into token in encrypted message
> -----------------------------------------------------
>
> Key: HDFS-13617
> URL: https://issues.apache.org/jira/browse/HDFS-13617
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Chen Liang
> Assignee: Chen Liang
> Priority: Major
> Attachments: HDFS-13617.001.patch, HDFS-13617.002.patch,
> HDFS-13617.003.patch, HDFS-13617.004.patch, HDFS-13617.005.patch
>
>
> This Jira allows NN to configurably wrap the QOP it has established with the
> client into the token message sent back to the client. The QOP is sent back
> in encrypted message, using BlockAccessToken encryption key as the key.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
