[ 
https://issues.apache.org/jira/browse/HDFS-14215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16749865#comment-16749865
 ] 

Surendra Singh Lilhore commented on HDFS-14215:
-----------------------------------------------

Thanks [~ayushtkn] for the patch.

#  Pls check the nameservice set size before using it. Better add assert logic 
for set size.
{code}
+    Set<FederationNamespaceInfo> nss = namenodeResolver.getNamespaces();
+    return (FsServerDefaults) rpcClient.invokeSingle(nss.iterator().next(),
+        method);
{code}
# Pls check the {{DFSClient#getServerDefaults()}} cache logic. With cache we 
can avoid extra RPC calls.

> RBF: GetServerDefaults and GetStoragePolicies are dependent on Availability 
> of Default NS
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-14215
>                 URL: https://issues.apache.org/jira/browse/HDFS-14215
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ayush Saxena
>            Assignee: Ayush Saxena
>            Priority: Major
>         Attachments: HDFS-14215-HDFS-13891-01.patch, 
> HDFS-14215-HDFS-13891-02.patch
>
>
> GetServerDefaults and GetStoragePolicies fetches from Default NS.Thus is 
> dependent on the availability of Default NS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to