[
https://issues.apache.org/jira/browse/HDDS-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751724#comment-16751724
]
Xiaoyu Yao commented on HDDS-991:
---------------------------------
Thanks [~ajayydv] for the patch. It looks great to me. I just have two minor
comments:
OMException.java
Line 129: NIT: suggested renaming to be consistent:
TOKEN_ERROR_INVALID_AUTH_METHOD-> INVALID_AUTH_METHOD
TOKEN_ERROR_INVALID_TOKEN->INVALID_TOKEN
TOKEN_ERROR_EXPIRED->TOKEN_EXPIRED
TOKEN_ERROR_OTHER? in which case will we use this? what's the difference
between this and UNKNOWN.
TestSecureOzoneCluster.java
Line 417/449/515: can we validate specific OMException code newly added here?
> Fix failures in TestSecureOzoneCluster
> --------------------------------------
>
> Key: HDDS-991
> URL: https://issues.apache.org/jira/browse/HDDS-991
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Ajay Kumar
> Assignee: Ajay Kumar
> Priority: Major
> Attachments: HDDS-991.00.patch, HDDS-991.01.patch
>
>
> Fix failures in TestSecureOzoneCluster
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
