[
https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doroszlai, Attila updated HDDS-974:
-----------------------------------
Target Version/s: 0.4.0
Status: Patch Available (was: In Progress)
Changes in addition to adding/using the new method:
* fix javadoc of {{ServiceInfo#getPort}}, which incorrectly stated that
{{null}} would be returned in some case
* remove unnecessary code from {{TestOzoneDatanodeShell#setup}} (probably
leftover of copy-paste from {{TestOzoneShell}})
* get rid of an unnecessary {{ArrayList}} creation for logging {{String[]}} in
both affected tests
* use {{findFirst()}} instead of {{collect(toList()).get(0)}}
* remove unused import
(I tried to restrict cleanup to the files already touched by the change.)
> Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell
> ------------------------------------------------------------------------
>
> Key: HDDS-974
> URL: https://issues.apache.org/jira/browse/HDDS-974
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Dinesh Chitlangia
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: newbie
> Attachments: HDDS-974.001.patch
>
>
> This jira has been filed based on [~ajayydv]'s [review comment
> |https://issues.apache.org/jira/browse/HDDS-960?focusedCommentId=16739807&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16739807]on
> HDDS-960
> 1. Add a method getServiceAddress(ServicePort port) in ServiceInfo
> 2. Use this method in TestOzoneShell in place of following snippet:
> {code:java}
> String omHostName = services.stream().filter(
> a -> a.getNodeType().equals(HddsProtos.NodeType.OM))
> .collect(Collectors.toList()).get(0).getHostname();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
