[ 
https://issues.apache.org/jira/browse/HDFS-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104592#comment-13104592
 ] 

Sanjay Radia commented on HDFS-2298:
------------------------------------

Not supporting overloaded methods is fine. BTW with Hadoop-7523 the case of 
overloaded  methods in different protocols will not be an issue since creating 
a  mixin interface will no longer be necessary. I haven't changed the servers 
to take advantage of this. However its okay for this patch to rename such 
conflicting methods.

The only snag is that with hadoop-7524 we would have an opportunity to provide 
compatibility with 20; that will  become a little trickier if the method names 
are changed; however 20 compatibility will be messy anyway..

Yes lets go head with renaming overloaded method. Also lets back port this to 
0.23.

> TestDfsOverAvroRpc is failing on trunk
> --------------------------------------
>
>                 Key: HDFS-2298
>                 URL: https://issues.apache.org/jira/browse/HDFS-2298
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>            Reporter: Aaron T. Myers
>            Assignee: Doug Cutting
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2298.patch, HDFS-2298.patch, HDFS-2298.patch
>
>
> The relevant bit of the error:
> {noformat}
> -------------------------------------------------------------------------------
> Test set: org.apache.hadoop.hdfs.TestDfsOverAvroRpc
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.486 sec <<< 
> FAILURE!
> testWorkingDirectory(org.apache.hadoop.hdfs.TestDfsOverAvroRpc)  Time 
> elapsed: 1.424 sec  <<< ERROR!
> org.apache.avro.AvroTypeException: Two methods with same name: delete
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to