[
https://issues.apache.org/jira/browse/HDDS-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753659#comment-16753659
]
Yiqun Lin commented on HDDS-974:
--------------------------------
Almost looks good to me, only one comment:
{code}
/**
- * Returns the port for given type, null if the service doesn't support
- * the type.
+ * Returns the port for given type.
*
* @param type the type of port.
* ex: RPC, HTTP, HTTPS, etc..
+ * @throws NullPointerException if the service doesn't support the given type
*/
@JsonIgnore
public int getPort(ServicePort.Type type) {
return ports.get(type);
}
{code}
Here the ports map will return null not NPE when service doesn't support the
given type I think.
> Add getServiceAddress method to ServiceInfo and use it in TestOzoneShell
> ------------------------------------------------------------------------
>
> Key: HDDS-974
> URL: https://issues.apache.org/jira/browse/HDDS-974
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Dinesh Chitlangia
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: newbie
> Attachments: HDDS-974.001.patch, HDDS-974.002.patch
>
>
> This jira has been filed based on [~ajayydv]'s [review comment
> |https://issues.apache.org/jira/browse/HDDS-960?focusedCommentId=16739807&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16739807]on
> HDDS-960
> 1. Add a method getServiceAddress(ServicePort port) in ServiceInfo
> 2. Use this method in TestOzoneShell in place of following snippet:
> {code:java}
> String omHostName = services.stream().filter(
> a -> a.getNodeType().equals(HddsProtos.NodeType.OM))
> .collect(Collectors.toList()).get(0).getHostname();
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
