[ 
https://issues.apache.org/jira/browse/HDFS-14202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16754177#comment-16754177
 ] 

Íñigo Goiri commented on HDFS-14202:
------------------------------------

For the numbers, I would try to use something more intuitive and put comments.
For example, you can put {{final int blockSize = 11 * 1024 * 1024; // 11MB}}.
Regarding the javadoc you currently have, those are not params or any javadoc 
entity.
It should be a regular java comment:
{code}
// bytesCopied: 21936966 byteCopied.
// timeUsed: 12000 milliseconds
// item: set DiskBalancerWorkItem bandwidth as 10
// Expect return sleep delay in milliseconds: sleep value = bytesCopied / 
(1024*1024*bandwidth in MB/milli) - timeUsed;
{code}

> "dfs.disk.balancer.max.disk.throughputInMBperSec" property is not working as 
> per set value.
> -------------------------------------------------------------------------------------------
>
>                 Key: HDFS-14202
>                 URL: https://issues.apache.org/jira/browse/HDFS-14202
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: diskbalancer
>    Affects Versions: 3.0.1
>            Reporter: Ranith Sardar
>            Assignee: Ranith Sardar
>            Priority: Major
>         Attachments: HDFS-14202.001.patch, HDFS-14202.002.patch, 
> HDFS-14202.003.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to