[
https://issues.apache.org/jira/browse/HDDS-1024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755650#comment-16755650
]
Bharat Viswanadham commented on HDDS-1024:
------------------------------------------
Hi [~linyiqun]
Thanks for the review.
Attached the patch to address other review comments.
Reason for not using GenericTestUtils.waitFor, is because we check whether it
is in containerset or not, it will immediately return true. (As we are not sure
whether this command is processed by datanode or not, so waiting for 10 seconds
to be sure command must have been processed by datanode. This is the reason for
not using GenericTestUtils.waitFor).
> Handle DeleteContainerCommand in the SCMDatanodeProtocolServer
> --------------------------------------------------------------
>
> Key: HDDS-1024
> URL: https://issues.apache.org/jira/browse/HDDS-1024
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: SCM
> Attachments: HDDS-1024.00.patch, HDDS-1024.01.patch,
> HDDS-1024.02.patch, HDDS-1024.03.patch, HDDS-1024.04.patch
>
>
> Right now, in the SCMDatanodeProtocolServer getCommandResponse()
> deleteContainerCommand is not handled, so deleteContainerCommand is not sent
> to Datanode.
>
> The deletecontainercommand request is sent for over replicated containers, so
> this over replication is currently broken because of this.
>
> Because of this we see below error:
>
> {code:java}
> java.lang.IllegalArgumentException: Not implemented
> at
> org.apache.hadoop.hdds.scm.server.SCMDatanodeProtocolServer.getCommandResponse(SCMDatanodeProtocolServer.java:345)
> at
> org.apache.hadoop.hdds.scm.server.SCMDatanodeProtocolServer.sendHeartbeat(SCMDatanodeProtocolServer.java:272)
> at
> org.apache.hadoop.ozone.protocolPB.StorageContainerDatanodeProtocolServerSideTranslatorPB.sendHeartbeat(StorageContainerDatanodeProtocolServerSideTranslatorPB.java:88)
> at
> org.apache.hadoop.hdds.protocol.proto.StorageContainerDatanodeProtocolProtos$StorageContainerDatanodeProtocolService$2.callBlockingMethod(StorageContainerDatanodeProtocolProtos.java:27753)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:822)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2682)
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
