[ https://issues.apache.org/jira/browse/HDDS-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755702#comment-16755702 ]
Mukul Kumar Singh commented on HDDS-997: ---------------------------------------- Thanks for working on this [~nilotpalnandi]. The patch looks good to me. Some minor comments. a) I feel for test_datanode_isolation_one_node, we will have 2 closed replica's as the other replica which is isolated will lag behind and should be in quasi closed state. b) Multiple lines are more than 80 characters > Add blockade Tests for scm isolation and mixed node isolation > ------------------------------------------------------------- > > Key: HDDS-997 > URL: https://issues.apache.org/jira/browse/HDDS-997 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Affects Versions: 0.4.0 > Reporter: Nilotpal Nandi > Assignee: Nilotpal Nandi > Priority: Major > Attachments: HDDS-997.001.patch, HDDS-997.002.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org