[ https://issues.apache.org/jira/browse/HDFS-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758643#comment-16758643 ]
Erik Krogen commented on HDFS-14250: ------------------------------------ v000 patch LGTM, only minor nit is that I would probably switch the order of these two lines, so that we give some time for the reader thread to advance before asserting that it was blocked: {code} assertEquals(0, readStatus.get()); Thread.sleep(100); {code} > [Standby Reads] msync should sync with active NameNode to fetch the latest > stateID > ---------------------------------------------------------------------------------- > > Key: HDFS-14250 > URL: https://issues.apache.org/jira/browse/HDFS-14250 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode > Reporter: Chao Sun > Assignee: Chao Sun > Priority: Major > Attachments: HDFS-14250.000.patch > > > Currently the {{msync}} call is a dummy operation to observer without really > syncing. Instead, it should: > # Get the latest stateID from active NN. > # Use the stateID to talk to observer NN and make sure it is synced. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org