[
https://issues.apache.org/jira/browse/HDFS-14210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760088#comment-16760088
]
Íñigo Goiri commented on HDFS-14210:
------------------------------------
I'm not sure we should do this for everybody all the time.
HASH_ALL and so on, yes they need it but HASH or others should be executed in
the ones that succeed.
We should have tests for different mount points, right now all of them are for
a single destination which actually don't really test this.
A few other minor comments:
* Fix the checkstyle.
* User {{assertNotEquals()}} instead of assert false for equals.
* Fix capitalization to {{testRemoveAclEntries()}}, {{testSetAcl()}} and
{{testModifyAclEntries()}}.
* Don't use javadoc comment in TestRouterACL#112,228.
* The test takes very long as we are setting up a cluster for every test; we
should make it @BeforeClass and @AfterClass.
* The mount points could be created in the beginning.
* You may want to set {{routerProtocol}} in the class itself instead of doing
it for every test. Actually, setting up the folders and deleting them could be
done in @Before and @After.
> RBF: ModifyACL should work over all the destinations
> ----------------------------------------------------
>
> Key: HDFS-14210
> URL: https://issues.apache.org/jira/browse/HDFS-14210
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Shubham Dewan
> Assignee: Shubham Dewan
> Priority: Major
> Attachments: HDFS-14210-HDFS-13891.002.patch,
> HDFS-14210-HDFS-13891.003.patch, HDFS-14210.001.patch
>
>
> 1) A mount point with multiple destinations.
> 2) ./bin/hdfs dfs -setfacl -m user:abc:rwx /testacl
> 3) where /testacl => /test1, /test2
> 4) command works for only one destination.
> ACL should be set on both of the destinations.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
