[
https://issues.apache.org/jira/browse/HDFS-14191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762149#comment-16762149
]
Íñigo Goiri commented on HDFS-14191:
------------------------------------
I think this is wrong:
{code}
public String getSafemode() {
if (!getRouter().isRouterState(RouterServiceState.SAFEMODE)) {
return "Safe mode is ON. " + this.getSafeModeTip();
}
} catch (IOException e) {
return "Failed to get safemode status. Please check router"
+ "log for more detail.";
}
return "";
}
{code}
The if seems to be reversed, it should be {{if
(getRouter().isRouterState(RouterServiceState.SAFEMODE))}}.
I'm opening a JIRA for this.
> RBF: Remove hard coded router status from FederationMetrics.
> ------------------------------------------------------------
>
> Key: HDFS-14191
> URL: https://issues.apache.org/jira/browse/HDFS-14191
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: 3.1.1
> Reporter: Ranith Sardar
> Assignee: Ranith Sardar
> Priority: Major
> Fix For: HDFS-13891
>
> Attachments: HDFS-14191-HDFS-13891.002.patch,
> HDFS-14191-HDFS-13891.003.patch, HDFS-14191.001.patch,
> IMG_20190109_023713.jpg, image-2019-01-08-16-05-34-736.png,
> image-2019-01-08-16-09-46-648.png
>
>
> Status value in "Router Information" and in Overview tab, is not matching for
> "SAFEMODE" condition.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
