[
https://issues.apache.org/jira/browse/HDDS-1048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16762295#comment-16762295
]
Yiqun Lin commented on HDDS-1048:
---------------------------------
The patch looks good overall, [~nandakumar131]. Some minor comments from me:
*NodeStateMap*
Line24: Unused import.
*NodeStateManager*
Line30: Unused import.
*TestDeadNodeHandler*
Line206: Why not refactor the test {{testStatisticsUpdate}} instead of ignoring
this?
In addition, javadoc warnings could be fixed as well, :).
> Remove SCMNodeStat from SCMNodeManager and use storage information from
> DatanodeInfo#StorageReportProto
> -------------------------------------------------------------------------------------------------------
>
> Key: HDDS-1048
> URL: https://issues.apache.org/jira/browse/HDDS-1048
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: SCM
> Affects Versions: 0.3.0
> Reporter: Nanda kumar
> Assignee: Nanda kumar
> Priority: Major
> Attachments: HDDS-1048.000.patch
>
>
> We don't have to maintain SCMNodeStat in SCMNodeManager anymore. This
> information can be obtained from {{DatanodeInfo#StorageReportProto}} inside
> NodeStateMap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
