[
https://issues.apache.org/jira/browse/HDFS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13106601#comment-13106601
]
Hadoop QA commented on HDFS-2294:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494820/HDFS-2289.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1262//console
This message is automatically generated.
> Download of commons-daemon TAR should not be under target
> ---------------------------------------------------------
>
> Key: HDFS-2294
> URL: https://issues.apache.org/jira/browse/HDFS-2294
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Fix For: 0.23.0, 0.24.0
>
> Attachments: HDFS-2289.patch
>
>
> Committed HDFS-2289 downloads commons-daemon TAR in the hadoop-hdfs/target/,
> earlier patches for HDFS-2289 were using hadoop-hdfs/download/ as the
> location for the download.
> The motivation not to use the 'target/' directory is that on every clean
> build the TAR will be downloaded from Apache archives. Using a 'download'
> directory this happens once per workspace.
> The patch was also adding the 'download/' directory to the .gitignore file
> (it should also be svn ignored).
> Besides downloading it only once, it allows to do a clean build in
> disconnected mode.
> IMO, the later is a nice developer capability.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
