[
https://issues.apache.org/jira/browse/HDFS-14258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16766155#comment-16766155
]
BELUGA BEHR edited comment on HDFS-14258 at 2/12/19 3:37 PM:
-------------------------------------------------------------
Thanks [~elgoiri]!
I added a unit test (and cleaned up existing tests a bit). Also updated the
GitHub PR if you prefer to look at it that way.
And the {{Math.abs}} is required. When doing the deltas... if DN is
reconfigured from 50 threads to 45 threads, that is a change of -5. To pull
five "tickets" from the semaphore, to decrease the number of threads that can
run, the code must request to acquire +5 ticket.
was (Author: belugabehr):
Thanks [~elgoiri]!
I added a unit test (and cleaned up existing tests a bit). Also updated the
GitHub PR if you prefer to look at it that way.
> Introduce Java Concurrent Package To DataXceiverServer Class
> ------------------------------------------------------------
>
> Key: HDFS-14258
> URL: https://issues.apache.org/jira/browse/HDFS-14258
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.2.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HDFS-14258.1.patch, HDFS-14258.2.patch,
> HDFS-14258.3.patch, HDFS-14258.4.patch, HDFS-14258.5.patch,
> HDFS-14258.6.patch, HDFS-14258.7.patch
>
>
> * Use Java concurrent package to replace current facilities in
> {{DataXceiverServer}}.
> * A little bit of extra clean up
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
