[ 
https://issues.apache.org/jira/browse/HDDS-1116?focusedWorklogId=199435&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-199435
 ]

ASF GitHub Bot logged work on HDDS-1116:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Feb/19 21:18
            Start Date: 15/Feb/19 21:18
    Worklog Time Spent: 10m 
      Work Description: prasanthj commented on pull request #491: HDDS-1116. 
Add java profiler servlet to the Ozone web servers
URL: https://github.com/apache/hadoop/pull/491#discussion_r257394453
 
 

 ##########
 File path: hadoop-ozone/dist/src/main/compose/ozone/docker-compose.yaml
 ##########
 @@ -18,6 +18,7 @@ version: "3"
 services:
    datanode:
       image: apache/hadoop-runner
+      privileged: true #required by the profiler
 
 Review comment:
   This can be avoided with initContainer running in privileged mode that 
updates the following
   ```
               sudo bash -c 'echo 1 > /proc/sys/kernel/perf_event_paranoid'
               sudo bash -c 'echo 0 > /proc/sys/kernel/kptr_restrict'
   ```
   with this initContainer will apply the required changes and will complete. 
main container can still run in non-previleged mode. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 199435)
    Time Spent: 20m  (was: 10m)

> Add java profiler servlet to the Ozone web servers
> --------------------------------------------------
>
>                 Key: HDDS-1116
>                 URL: https://issues.apache.org/jira/browse/HDDS-1116
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.4.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Thanks to [~gopalv] we learned that [~prasanth_j] implemented a helper 
> servlet in Hive to initialize new [async 
> profiler|https://github.com/jvm-profiling-tools/async-profiler] sessions and 
> provide the svg based flame graph over HTTP. (see HIVE-20202)
> It seems to very useful as with this approach the profiling could be very 
> easy.
> This patch imports the servlet from the Hive code base to the Ozone code base 
> with minor modification (to make it work with our servlet containers)
>  * The two servlets are unified to one
>  * Streaming the svg to the browser based on IOUtils.copy 
>  * Output message is improved
> By default the profile servlet is turned off, but you can enable it with 
> 'hdds.profiler.endpoint.enabled=true' ozone-site.xml settings. In that case 
> you can access the /prof endpoint from scm,om,s3g. 
> You should upload the async profiler first 
> (https://github.com/jvm-profiling-tools/async-profiler) and set the 
> ASYNC_PROFILER_HOME environment variable to find it. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to