[
https://issues.apache.org/jira/browse/HDDS-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769790#comment-16769790
]
Ajay Kumar commented on HDDS-1101:
----------------------------------
[~anu] thanks for the patch. LGTM. Few minor comments:
SCM
* L523 Shall we add scm id as suffix. i.e "scm-<scmid>@hostname".
* Also do we need any validation for hostname used in subject.Ideally in most
of the cases it will work fine but may cause an error in some cases when
hostname is not configured properly.
* L538 Shall we add another resultcode for CA initialization failure? something
like "SCM_CA_INITIALIZATION"
Seems this is initial patch, are we planning to add jira specific unit tests in
following patch?
> SCM CA: Write Certificate information to SCM Metadata
> -----------------------------------------------------
>
> Key: HDDS-1101
> URL: https://issues.apache.org/jira/browse/HDDS-1101
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Attachments: HDDS-1101.000.patch, HDDS-1101.001.patch
>
>
> Make SCM CA write to the Metadata layer of SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
