[
https://issues.apache.org/jira/browse/HDDS-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771596#comment-16771596
]
Yiqun Lin commented on HDDS-1130:
---------------------------------
The patch almost looks good to me, two minor comments:
* Can we define a static variable {{NUM_PIPELINES}} to replace hard-coded
value {{100000}}?
* We can use {{GenericTestUtils#waitFor}} to replace thread sleep:
{noformat}
GenericTestUtils.waitFor(() -> {
return !blockManager.isScmInChillMode();
}, 100, 60000);
{noformat}
> Make BenchMarkBlockManager multi-threaded
> -----------------------------------------
>
> Key: HDDS-1130
> URL: https://issues.apache.org/jira/browse/HDDS-1130
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-1130.001.patch
>
>
> Currently BenchMarkBlockManager is run by a single thread. We can make it
> multi-threaded in order to have a better understanding of allocateBlock call
> performance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
