[
https://issues.apache.org/jira/browse/HDDS-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772236#comment-16772236
]
Dinesh Chitlangia commented on HDDS-1135:
-----------------------------------------
[~shashikant] thanks for filing the jira.
[~elek] thanks for the inputs, that was helpful.
Attached patch 00 for review.
I verified manually by building tar and the extracting it.
> Ozone jars are missing in the Ozone Snapshot tar
> ------------------------------------------------
>
> Key: HDDS-1135
> URL: https://issues.apache.org/jira/browse/HDDS-1135
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Shashikant Banerjee
> Assignee: Dinesh Chitlangia
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-1135.00.patch
>
>
> After executing an ozone dist build the library jars are missing from the
> created tar file.
> The problem is on the maven side. The tar file creation is called before the
> jar copies.
> {code:java}
> cd hadoop-ozone/dist
> mvn clean package | grep "\-\-\-"{code}
> {code:java}
> [INFO] ----------------< org.apache.hadoop:hadoop-ozone-dist
> >-----------------
> [INFO] --------------------------------[ pom
> ]---------------------------------
> [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ hadoop-ozone-dist
> ---
> [INFO] --- maven-antrun-plugin:1.7:run (create-testdirs) @ hadoop-ozone-dist
> ---
> [INFO] --- maven-remote-resources-plugin:1.5:process (default) @
> hadoop-ozone-dist ---
> [INFO] --- exec-maven-plugin:1.3.1:exec (dist) @ hadoop-ozone-dist ---
> [INFO] --- exec-maven-plugin:1.3.1:exec (tar-ozone) @ hadoop-ozone-dist ---
> [INFO] --- maven-site-plugin:3.6:attach-descriptor (attach-descriptor) @
> hadoop-ozone-dist ---
> [INFO] --- maven-dependency-plugin:3.0.2:build-classpath
> (add-classpath-descriptor) @ hadoop-ozone-dist ---
> [INFO] --- maven-dependency-plugin:3.0.2:copy (copy-classpath-files) @
> hadoop-ozone-dist ---
> [INFO] --- maven-dependency-plugin:3.0.2:copy-dependencies (copy-jars) @
> hadoop-ozone-dist ---
> [INFO] --- maven-jar-plugin:2.5:test-jar (default) @ hadoop-ozone-dist
> ---{code}
> The right order of the plugin executions are:
> * Call 'dist' (dist-layout-stitching, it cleans the destination directory)
> * Copy the jar files (copy-classpath-files, copy-jars)
> * Create the tar package (tar-ozone)
> It could be done with adjusting the maven phases in the pom.xml
> I would suggest to move 'dist' to the 'compile' phase, move
> 'copy-classpath-files' and 'copy-jars' to the 'prepare-package' phase, and
> keep 'tar-ozone' at the 'package' phase.
> With this setup we can be sure that the steps are executed in the right order.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
