[
https://issues.apache.org/jira/browse/HDDS-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772771#comment-16772771
]
Elek, Marton commented on HDDS-891:
-----------------------------------
Thanks the answer [~aw]
Sorry for the confusion. I think there are two questions which are mixed here.
# I would like to fix HDDS-146. It was not clear for me what is the wrong. If
I understood well, you suggest to double quote the $DOCKER_INTERACTIVE_RUN
variable in the docker run line. I think it's a false positive report as
DOCKER_INTERACTIVE_RUN should be either an empty string or unset (which will be
replaced by "-i -t"). I think it shouldn't be quoted because in that case
instead of -i -t we would add just one argument ('-i -t'). But please let me
know if I am wrong. (I can add a check if it initial value anything other than
an empty string.)
# "_Cutting back on options just because you think they don't apply to Ozone
is almost entirely incorrect."_ Please not that I am totally on the _opposite_
side. I would like to add MORE tests and MORE strict tests _in addition_ to the
existing tests. (Especially: running docker based acceptance tests, run ALL the
hdds/ozone unit tests all the time, not just for the changed projects, check
ALL the findbugs/checkstyle issues not just the new ones).
# I am convinced to run the more strict tests in addition to the existing
yetus tests. Please let me know If I can do something to get Yetus results for
the PR-s.
> Create customized yetus personality for ozone
> ---------------------------------------------
>
> Key: HDDS-891
> URL: https://issues.apache.org/jira/browse/HDDS-891
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
>
> Ozone pre commit builds (such as
> https://builds.apache.org/job/PreCommit-HDDS-Build/) use the official hadoop
> personality from the yetus personality.
> Yetus personalities are bash scripts which contain personalization for
> specific builds.
> The hadoop personality tries to identify which project should be built and
> use partial build to build only the required subprojects because the full
> build is very time consuming.
> But in Ozone:
> 1.) The build + unit tests are very fast
> 2.) We don't need all the checks (for example the hadoop specific shading
> test)
> 3.) We prefer to do a full build and full unit test for hadoop-ozone and
> hadoop-hdds subrojects (for example the hadoop-ozone integration test always
> should be executed as it contains many generic unit test)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
