[
https://issues.apache.org/jira/browse/HDDS-1095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773555#comment-16773555
]
Bharat Viswanadham edited comment on HDDS-1095 at 2/21/19 1:00 AM:
-------------------------------------------------------------------
Hi Mukul,
Build compilation is still failing. We need to update ScmBlockTestingClient.java
One more comment from me.
# We cannot check below condition to return an error case, as
BlockManagerImpl.allocateBlock can return null. As if we just check count, one
of allocateBlock receives null, we fail with NPE in for loop in Line 88
## if (allocatedBlocks.size() < request.getNumBlocks())
was (Author: bharatviswa):
Hi Mukul,
Build compilation is still failing. We need to update ScmBlockTestingClient.java
One more comment from me.
# We cannot check below condition to return an error case, as
BlockManagerImpl.allocateBlock can return null.
## if (allocatedBlocks.size() < request.getNumBlocks())
> OzoneManager#openKey should do multiple block allocations in a single SCM rpc
> call
> ----------------------------------------------------------------------------------
>
> Key: HDDS-1095
> URL: https://issues.apache.org/jira/browse/HDDS-1095
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-1095.001.patch, HDDS-1095.002.patch
>
>
> Currently in KeyManagerImpl#openKey, for a large key allocation, multiple
> blocks are allocated in different rpc calls. If the key length is already
> known, then multiple blocks can be allocated in one rpc call to SCM.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
