[jira] [Commented] (HDFS-687) FS setSpaceQuota should warn when user attempts to set quota of very large amount.

[Uma Maheswara Rao G (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109293#comment-13109293
 ] 

Uma Maheswara Rao G commented on HDFS-687:
------------------------------------------

Here one more problem is CommandFormat is taking the min rang and max ranges as 
int values.

I am planning it to increase it to long values.

Changing the below code
{code}
public CommandFormat(int min, int max, String ... possibleOpt) {
{code}
to 
{code}
public CommandFormat(long min, long max, String ... possibleOpt) {
{code}

Do you think any issues with it?

{quote}
■parse is throwing IlligalArgumentException if max value is topped. I wonder 
why this isn't happening
{quote}
CommandFormat bevavior is that, it will take min and max ranges, if they are 
not in that boundary then it will throw exception.

Thanks
Uma

> FS setSpaceQuota should warn  when user attempts to set quota of very large 
> amount.
> -----------------------------------------------------------------------------------
>
>                 Key: HDFS-687
>                 URL: https://issues.apache.org/jira/browse/HDFS-687
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ravi Phulari
>
> FS -setSpaceQuota has upper limit of  Long.Max_Value  ( 
> http://hadoop.apache.org/common/docs/current/hdfs_quota_admin_guide.html )
> There is no warning message when user attempts to set a quota of very large 
> amount .
> {noformat}
> [hadoop@0035 hadoop]$ bin/hadoop dfsadmin  -setQuota 9223372036854775 
> /user/rphulari
> [hadoop@0035 hadoop]$ bin/hadoop dfsadmin  -setQuota 9223372036854775456 
> /user/rphulari
> [hadoop@0035 hadoop]$ bin/hadoop dfsadmin  -setQuota 9223372036854775456456 
> /user/rphulari
> setQuota: For input string: "9223372036854775456456"
> Usage: java DFSAdmin [-setQuota <quota> <dirname>...<dirname>]
> {noformat}
> HDFS should warn user of maximum range of quota which can be applied.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira