[
https://issues.apache.org/jira/browse/HDDS-1158?focusedWorklogId=202967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-202967
]
ASF GitHub Bot logged work on HDDS-1158:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Feb/19 02:33
Start Date: 23/Feb/19 02:33
Worklog Time Spent: 10m
Work Description: hanishakoneru commented on pull request #512:
HDDS-1158. TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error.
URL: https://github.com/apache/hadoop/pull/512#discussion_r259561458
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHA.java
##########
@@ -150,17 +152,27 @@ private void testCreateVolume(boolean checkSuccess)
throws Exception {
createVolumeArgs.setUserName(userName);
createVolumeArgs.setAdminName(adminName);
- storageHandler.createVolume(createVolumeArgs);
+ try {
+ storageHandler.createVolume(createVolumeArgs);
- VolumeArgs getVolumeArgs = new VolumeArgs(volumeName, userArgs);
- VolumeInfo retVolumeinfo = storageHandler.getVolumeInfo(getVolumeArgs);
+ VolumeArgs getVolumeArgs = new VolumeArgs(volumeName, userArgs);
+ VolumeInfo retVolumeinfo = storageHandler.getVolumeInfo(getVolumeArgs);
- if (checkSuccess) {
- Assert.assertTrue(retVolumeinfo.getVolumeName().equals(volumeName));
- Assert.assertTrue(retVolumeinfo.getOwner().getName().equals(userName));
- } else {
- // Verify that the request failed
- Assert.assertTrue(retVolumeinfo.getVolumeName().isEmpty());
+ if (checkSuccess) {
+ Assert.assertTrue(retVolumeinfo.getVolumeName().equals(volumeName));
+ Assert.assertTrue(retVolumeinfo.getOwner().getName().equals(userName));
+ } else {
+ // Verify that the request failed
+ Assert.assertTrue(retVolumeinfo.getVolumeName().isEmpty());
+ Assert.fail("There is no quorum. Request should have failed");
+ }
+ } catch (OMException e) {
+ if (!checkSuccess) {
+ GenericTestUtils.assertExceptionContains(
+ "RaftRetryFailureException", e);
Review comment:
Hi @bharatviswa504,
This particular test case if for when we have 2 OM nodes down. So even with
retry and failover logic implemented, the request should eventually fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 202967)
Time Spent: 50m (was: 40m)
> TestOzoneManagerHA.testTwoOMNodesDown is failing with ratis error
> -----------------------------------------------------------------
>
> Key: HDDS-1158
> URL: https://issues.apache.org/jira/browse/HDDS-1158
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> h3. Error Message
> {code:java}
> org.apache.ratis.protocol.RaftRetryFailureException: Failed
> RaftClientRequest:client-4D77D2A8F653->omNode-3@group-523986131536, cid=9,
> seq=0 RW,
> org.apache.hadoop.ozone.om.ratis.OzoneManagerRatisClient$$Lambda$373/2067504307@6afa0221
> for 10 attempts with RetryLimited(maxAttempts=10, sleepTime=100ms){code}
> Stacktrace
> {code:java}
> INTERNAL_ERROR org.apache.hadoop.ozone.om.exceptions.OMException:
> org.apache.ratis.protocol.RaftRetryFailureException: Failed
> RaftClientRequest:client-4D77D2A8F653->omNode-3@group-523986131536, cid=9,
> seq=0 RW,
> org.apache.hadoop.ozone.om.ratis.OzoneManagerRatisClient$$Lambda$373/2067504307@6afa0221
> for 10 attempts with RetryLimited(maxAttempts=10, sleepTime=100ms) at
> org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB.handleError(OzoneManagerProtocolClientSideTranslatorPB.java:586)
> at
> org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB.createVolume(OzoneManagerProtocolClientSideTranslatorPB.java:230)
> at
> org.apache.hadoop.ozone.web.storage.DistributedStorageHandler.createVolume(DistributedStorageHandler.java:179)
> at
> org.apache.hadoop.ozone.om.TestOzoneManagerHA.testCreateVolume(TestOzoneManagerHA.java:153)
> at
> org.apache.hadoop.ozone.om.TestOzoneManagerHA.testTwoOMNodesDown(TestOzoneManagerHA.java:138)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498) at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at
> org.junit.rules.ExpectedException$ExpectedExceptionStatement.evaluate(ExpectedException.java:168)
> at
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74){code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
