[
https://issues.apache.org/jira/browse/HDDS-1072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776261#comment-16776261
]
Yiqun Lin commented on HDDS-1072:
---------------------------------
Just take a quick review, some initial comment from me:
* Can we also add some unit tests for the {{MaxFailovers}} and {{MaxRetries}}
limitation behaviour? Since we Implement fine-grained retry policy.
* The method {{OMProxyInfo#proxyName}} is never used.
* The patch is not complete, seems we missed the leaderOmId field in
{{OMResponse}}. Then I caught the error in following
{code:java}
if (omResponse.hasLeaderOmId() && omFailoverProxyProvider != null) {
String leaderOmId = omResponse.getLeaderOmId();
String oldLeaderOmId = omFailoverProxyProvider
.getCurrentProxyOMNodeId();
...
{code}
> Implement RetryProxy and FailoverProxy for OM client
> ----------------------------------------------------
>
> Key: HDDS-1072
> URL: https://issues.apache.org/jira/browse/HDDS-1072
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: OM
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: HDDS-1072.001.patch
>
>
> RPC Client should implement a retry and failover proxy provider to failover
> between OM Ratis clients. The failover should occur in two scenarios:
> # When the client is unable to connect to the OM (either because of network
> issues or because the OM is down). The client retry proxy provider should
> failover to next OM in the cluster.
> # When OM Ratis Client receives a response from the Ratis server for its
> request, it also gets the LeaderId of server which processed this request
> (the current Leader OM nodeId). This information should be propagated back to
> the client. The Client failover Proxy provider should failover to the leader
> OM node. This helps avoid an extra hop from Follower OM Ratis Client to
> Leader OM Ratis server for every request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
