[
https://issues.apache.org/jira/browse/HDDS-1115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16776923#comment-16776923
]
Steve Loughran commented on HDDS-1115:
--------------------------------------
* Was there no way this couldn't have just been done with a <profile> in the
main build.xml, or was the complication that there was no easy way to stop the
IDE finding all the other artifacts?
* I worry that the distribution bits of the new POM match those of
hadoop-trunk. Is there a risk that someone might accidentally do a release of
the ozone artifacts alone? It may be safer to cut back on what's there, as its
not needed for the use cases list above
Do you now plan to cut the hdds profile from pom.xml? If so, file a HADOOP-
JIRA. thx
> Provide ozone specific top-level pom.xml
> ----------------------------------------
>
> Key: HDDS-1115
> URL: https://issues.apache.org/jira/browse/HDDS-1115
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Ozone build process doesn't require the pom.xml in the top level hadoop
> directory as we use hadoop 3.2 artifacts as parents of hadoop-ozone and
> hadoop-hdds. The ./pom.xml is used only to include the
> hadoop-ozone/hadoop-hdds projects in the maven reactor.
> From command line, it's easy to build only the ozone artifacts:
> {code}
> mvn clean install -Phdds -am -pl :hadoop-ozone-dist
> -Danimal.sniffer.skip=true -Denforcer.skip=true
> {code}
> Where: '-pl' defines the build of the hadoop-ozone-dist project
> and '-am' defines to build all of the dependencies from the source tree
> (hadoop-ozone-common, hadoop-hdds-common, etc.)
> But this filtering is available only from the command line.
> With providing a lightweight pom.ozone.xml we can achieve the same:
> * We can open only hdds/ozone projects in the IDE/intellij. It makes the
> development faster as IDE doesn't need to reindex all the sources all the
> time + it's easy to execute checkstyle/findbugs plugins of the intellij to
> the whole project.
> * Longer term we should create an ozone specific source artifact (currently
> the source artifact for hadoop and ozone releases are the same) which also
> requires a simplified pom.
> In this patch I also added the .mvn directory to the .gitignore file.
> With
> {code}
> mkdir -p .mvn && echo "-f ozone.pom.xml" > .mvn/maven.config" you can persist
> the usage of the ozone.pom.xml for all the subsequent builds (in the same dir)
> How to test?
> Just do a 'mvn -f ozonze.pom.xml clean install -DskipTests'
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
