[ 
https://issues.apache.org/jira/browse/HDFS-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112709#comment-13112709
 ] 

Benoy Antony commented on HDFS-2290:
------------------------------------

Regarding the change in test :

  // corrupt the block on datanode dnIndex
+    // the indexes change once the nodes are restarted.
+    // But the datadirectory will not change
+    assertTrue(cluster.corruptReplica(block.getBlockName(), dnIndex));
+
+    DataNodeProperties dnProps = cluster.stopDataNode(0);

This is correct since   cluster.stopDataNode(0);  removes the first node so 
that the node at index 1 moves to index 0.
cluster.restartDataNode ()   adds the new node (previously 0th node)  at the 
end of the list.

I also indicated this in the comments. ("the indexes change once the nodes are 
restarted. But the datadirectory will not change") But looks like , they were 
not clear.

This could be the reason for failure in trunk.  John's suggestion seems to be 
better than  sleeping hard for 3 seconds.


> Block with corrupt replica is not getting replicated
> ----------------------------------------------------
>
>                 Key: HDFS-2290
>                 URL: https://issues.apache.org/jira/browse/HDFS-2290
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Shvachko
>            Assignee: Benoy Antony
>              Labels: blockmanagement, replication
>             Fix For: 0.22.0
>
>         Attachments: HDFS-2290_0.22.patch, HDFS-2290_022.patch, 
> HDFS-2290_022.patch, HDFS-2290_trunk.patch
>
>
> A block has one replica marked as corrupt and two good ones. countNodes() 
> correctly detects that there are only 2 live replicas, and fsck reports the 
> block as under-replicated. But ReplicationMonitor never schedules replication 
> of good replicas.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to