[
https://issues.apache.org/jira/browse/HDFS-14247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778793#comment-16778793
]
Íñigo Goiri commented on HDFS-14247:
------------------------------------
Thanks [~marvelrock] for pointing that one out.
As mentioned before the addition to the tree is done in {{addDatanode()}} which
is called 4 lines later and has no issues with:
{code}
nodeDescr.setSoftwareVersion(nodeReg.getSoftwareVersion());
resolveUpgradeDomain(nodeDescr);
{code}
+1 on [^HDFS-14247.001.patch]
> Repeat adding node description into network topology
> ----------------------------------------------------
>
> Key: HDFS-14247
> URL: https://issues.apache.org/jira/browse/HDFS-14247
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 3.3.0
> Reporter: HuangTao
> Priority: Minor
> Attachments: HDFS-14247.001.patch
>
>
> I find there is a duplicate code to add nodeDescr to networktopology in the
> DatanodeManager.java#registerDatanode.
> It firstly call networktopology.add(nodeDescr), and then call
> addDatanode(nodeDescr) to add nodeDescr again
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
