[
https://issues.apache.org/jira/browse/HDDS-1088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779059#comment-16779059
]
Shashikant Banerjee commented on HDDS-1088:
-------------------------------------------
Thanks [~nilotpalnandi] for updating the patch. The patch looks god to me
overall. I have few comments:
1) The patch does regex matching to figure out the container yaml file on
datanodes to check what the replica state is. Can you please add more comments
elaborating what all is being done there.
2) Individually going to the datanodes and navigating the container path layout
to read the container yaml file to check the container status seem to be hacky.
If the container path layout changes, the tests will start to fail. I think ,
may be, we can build a tool to retrieve container status from individual
datanodes and use it in the test for the same. Such a tool will help in
debugging as well.
> Add blockade Tests to test Replica Manager
> ------------------------------------------
>
> Key: HDDS-1088
> URL: https://issues.apache.org/jira/browse/HDDS-1088
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Nilotpal Nandi
> Assignee: Nilotpal Nandi
> Priority: Major
> Attachments: HDDS-1088.001.patch, HDDS-1088.002.patch
>
>
> We need to add tests for testing Replica Manager for scenarios like loss of
> node, adding new nodes, under-replicated containers
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
