[
https://issues.apache.org/jira/browse/HDDS-1113?focusedWorklogId=205248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-205248
]
ASF GitHub Bot logged work on HDDS-1113:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Feb/19 17:08
Start Date: 27/Feb/19 17:08
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #490: HDDS-1113. Remove
default dependencies from hadoop-ozone project
URL: https://github.com/apache/hadoop/pull/490#issuecomment-467946883
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 23 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 77 | Maven dependency ordering for branch |
| +1 | mvninstall | 977 | trunk passed |
| -1 | compile | 93 | hadoop-ozone in trunk failed. |
| -1 | mvnsite | 98 | hadoop-ozone in trunk failed. |
| +1 | shadedclient | 2133 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 221 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 13 | Maven dependency ordering for patch |
| +1 | mvninstall | 501 | the patch passed |
| -1 | compile | 97 | hadoop-ozone in the patch failed. |
| -1 | javac | 97 | hadoop-ozone in the patch failed. |
| -1 | mvnsite | 91 | hadoop-ozone in the patch failed. |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 11 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 760 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 203 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 608 | hadoop-ozone in the patch failed. |
| +1 | unit | 38 | common in the patch passed. |
| +1 | unit | 28 | client in the patch passed. |
| +1 | unit | 37 | ozone-manager in the patch passed. |
| +1 | unit | 28 | objectstore-service in the patch passed. |
| +1 | unit | 37 | s3gateway in the patch passed. |
| -1 | unit | 539 | integration-test in the patch failed. |
| -1 | unit | 74 | tools in the patch failed. |
| +1 | asflicense | 31 | The patch does not generate ASF License warnings. |
| | | 5788 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.ozShell.TestOzoneShell |
| | hadoop.ozone.freon.TestFreonWithDatanodeFastRestart |
| | hadoop.ozone.freon.TestRandomKeyGenerator |
| | hadoop.ozone.ozShell.TestOzoneShell |
| | hadoop.ozone.freon.TestFreonWithDatanodeFastRestart |
| | hadoop.ozone.freon.TestRandomKeyGenerator |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/490 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml |
| uname | Linux 5b565315a3f0 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 6c8c422 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/branch-compile-hadoop-ozone.txt
|
| mvnsite |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/branch-mvnsite-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/patch-compile-hadoop-ozone.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/patch-compile-hadoop-ozone.txt
|
| mvnsite |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/patch-mvnsite-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/patch-unit-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/artifact/out/patch-unit-hadoop-ozone_tools.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/testReport/ |
| Max. process+thread count | 3725 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone hadoop-ozone/common hadoop-ozone/client
hadoop-ozone/ozone-manager hadoop-ozone/objectstore-service
hadoop-ozone/s3gateway hadoop-ozone/integration-test hadoop-ozone/tools U:
hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-490/2/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 205248)
Time Spent: 1h (was: 50m)
> Remove default dependencies from hadoop-ozone project
> -----------------------------------------------------
>
> Key: HDDS-1113
> URL: https://issues.apache.org/jira/browse/HDDS-1113
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There are two ways to define common dependencies with maven:
> 1.) put all the dependencies to the parent project and inherit them
> 2.) get all the dependencies via transitive dependencies
> TLDR; I would like to switch from 1 to 2 in hadoop-ozone
> My main problem with the first approach that all the child project get a lot
> of dependencies independent if they need them or not. Let's imagine that I
> would like to create a new project (for example a java csi implementation) It
> doesn't need ozone-client, ozone-common etc, in fact it conflicts with
> ozone-client. But these jars are always added as of now.
> Using transitive dependencies is more safe: we can add the dependencies where
> we need them and all of the other dependent projects will use them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
