[
https://issues.apache.org/jira/browse/HDFS-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114792#comment-13114792
]
Uma Maheswara Rao G commented on HDFS-2363:
-------------------------------------------
Test failures are not related to this patch!
Since this is re-factoring, not included new tests. Existing Tests should
ensure functionality.
> Move datanodes size printing to BlockManager from FSNameSystem's metasave API
> -----------------------------------------------------------------------------
>
> Key: HDFS-2363
> URL: https://issues.apache.org/jira/browse/HDFS-2363
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: name-node
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HDFS-2363.patch
>
>
> {code}
> final List<DatanodeDescriptor> live = new
> ArrayList<DatanodeDescriptor>();
> final List<DatanodeDescriptor> dead = new
> ArrayList<DatanodeDescriptor>();
> blockManager.getDatanodeManager().fetchDatanodes(live, dead, false);
> out.println("Live Datanodes: "+live.size());
> out.println("Dead Datanodes: "+dead.size());
> blockManager.metaSave(out);
> {code}
> Logically all the dataNode related logic can be moved to BlockManager.
> So, here metaSave API is getting the DataNodes details from blockManager to
> FsNameSystem and after printing the details again it is giving the control to
> blockManager.
> It will be good to move the DNs size printing code also to BlockManager.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
