[ 
https://issues.apache.org/jira/browse/HDFS-14254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16783590#comment-16783590
 ] 

Íñigo Goiri commented on HDFS-14254:
------------------------------------

Thanks [~RANith] for the update.
A couple comments:
* I think we should do some actual check for the ACLs in 
{{TestRouterRPCMultipleDestinationMountTableResolver}}. Currently we are just 
checking that they are there. Can we check for the AclEntry values?
* This is more like a personal preference but the {{if}} blocks in 
{{RouterClientProtocol#getFileInfoAll()}} have a lot of break lines which given 
the keys don't add much. Can we remove those extra break lines (1713, 1717 and 
1721)?

> RBF: Getfacl gives a wrong acl entries when the order of the mount table set 
> to HASH_ALL or RANDOM
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-14254
>                 URL: https://issues.apache.org/jira/browse/HDFS-14254
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Shubham Dewan
>            Assignee: Ranith Sardar
>            Priority: Major
>         Attachments: HDFS-14254-HDFS-13891.000.patch, 
> HDFS-14254-HDFS-13891.001.patch, HDFS-14254-HDFS-13891.002.patch, 
> HDFS-14254-HDFS-13891.003.patch
>
>
> ACL entries are missing when Order is set to HASH_ALL or RANDOM



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to