[
https://issues.apache.org/jira/browse/HDDS-1193?focusedWorklogId=207439&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207439
]
ASF GitHub Bot logged work on HDDS-1193:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/19 21:28
Start Date: 04/Mar/19 21:28
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #534:
HDDS-1193. Refactor ContainerChillModeRule and DatanodeChillMode rule.
URL: https://github.com/apache/hadoop/pull/534#discussion_r262250483
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/chillmode/ContainerChillModeRule.java
##########
@@ -96,12 +92,36 @@ public void process(NodeRegistrationContainerReport
reportsProto) {
}
}
});
+ }
+
+ @Override
+ public void onMessage(NodeRegistrationContainerReport
+ nodeRegistrationContainerReport, EventPublisher publisher) {
+
+ // TODO: when we have remove handlers, we can remove getInChillmode check
+ if (chillModeManager.getInChillMode()) {
+ if (validate()) {
Review comment:
This check is added, suppose this rule is already satisfied, I don't need to
process it, so that is the reason for the first check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 207439)
Time Spent: 0.5h (was: 20m)
> Refactor ContainerChillModeRule and DatanodeChillMode rule
> ----------------------------------------------------------
>
> Key: HDDS-1193
> URL: https://issues.apache.org/jira/browse/HDDS-1193
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The main intention of this Jira is to have all rules look in a similar way of
> handling events.
> In this Jira, did the following changes:
> # Both DatanodeRule and ContainerRule implements EventHandler and listen for
> NodeRegistrationContainerReport
> # Update ScmChillModeManager not to handle any events. (As each rule need to
> handle an event, and work on that rule)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
