[ 
https://issues.apache.org/jira/browse/HDDS-1213?focusedWorklogId=207740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207740
 ]

ASF GitHub Bot logged work on HDDS-1213:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Mar/19 10:35
            Start Date: 05/Mar/19 10:35
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on issue #549: HDDS-1213. 
Support plain text S3 MPU initialization request
URL: https://github.com/apache/hadoop/pull/549#issuecomment-469629985
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 19 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | -1 | test4tests | 0 | The patch doesn't appear to include any new or 
modified tests.  Please justify why no new tests are needed for this patch. 
Also please list what manual steps were performed to verify this patch. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 47 | Maven dependency ordering for branch |
   | +1 | mvninstall | 1064 | trunk passed |
   | -1 | compile | 45 | hadoop-ozone in trunk failed. |
   | +1 | checkstyle | 26 | trunk passed |
   | -1 | mvnsite | 29 | dist in trunk failed. |
   | +1 | shadedclient | 815 | branch has no errors when building and testing 
our client artifacts. |
   | 0 | findbugs | 0 | Skipped patched modules with no Java source: 
hadoop-ozone/dist |
   | +1 | findbugs | 34 | trunk passed |
   | +1 | javadoc | 37 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 12 | Maven dependency ordering for patch |
   | -1 | mvninstall | 17 | dist in the patch failed. |
   | -1 | compile | 41 | hadoop-ozone in the patch failed. |
   | -1 | javac | 41 | hadoop-ozone in the patch failed. |
   | +1 | checkstyle | 19 | the patch passed |
   | -1 | mvnsite | 19 | dist in the patch failed. |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 808 | patch has no errors when building and testing 
our client artifacts. |
   | 0 | findbugs | 0 | Skipped patched modules with no Java source: 
hadoop-ozone/dist |
   | +1 | findbugs | 39 | the patch passed |
   | +1 | javadoc | 33 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 33 | s3gateway in the patch passed. |
   | -1 | unit | 22 | dist in the patch failed. |
   | +1 | asflicense | 25 | The patch does not generate ASF License warnings. |
   | | | 3329 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/549 |
   | Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall 
 mvnsite  unit  shadedclient  findbugs  checkstyle  |
   | uname | Linux 1c6f25d86f31 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed 
Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 0aefe28 |
   | maven | version: Apache Maven 3.3.9 |
   | Default Java | 1.8.0_191 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/artifact/out/branch-compile-hadoop-ozone.txt
 |
   | mvnsite | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/artifact/out/branch-mvnsite-hadoop-ozone_dist.txt
 |
   | findbugs | v3.1.0-RC1 |
   | mvninstall | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/artifact/out/patch-mvninstall-hadoop-ozone_dist.txt
 |
   | compile | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/artifact/out/patch-compile-hadoop-ozone.txt
 |
   | javac | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/artifact/out/patch-compile-hadoop-ozone.txt
 |
   | mvnsite | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/artifact/out/patch-mvnsite-hadoop-ozone_dist.txt
 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/artifact/out/patch-unit-hadoop-ozone_dist.txt
 |
   |  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/testReport/ |
   | Max. process+thread count | 327 (vs. ulimit of 5500) |
   | modules | C: hadoop-ozone/s3gateway hadoop-ozone/dist U: hadoop-ozone |
   | Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-549/3/console |
   | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 207740)
    Time Spent: 1.5h  (was: 1h 20m)

> Support plain text S3 MPU initialization request
> ------------------------------------------------
>
>                 Key: HDDS-1213
>                 URL: https://issues.apache.org/jira/browse/HDDS-1213
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: S3
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Blocker
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> S3 Multi-Part-Upload (MPU) is implemented recently in the Ozone s3 gateway. 
> We have extensive testing with using 'aws s3api' application which is passed.
> But it turned out that the more simple `aws s3 cp` command fails with _405 
> Media type not supported error_ message
> The root cause of this issue is the JAXRS implementation of the multipart 
> upload method:
> {code}
>   @POST
>   @Produces(MediaType.APPLICATION_XML)
>   public Response multipartUpload(
>       @PathParam("bucket") String bucket,
>       @PathParam("path") String key,
>       @QueryParam("uploads") String uploads,
>       @QueryParam("uploadId") @DefaultValue("") String uploadID,
>       CompleteMultipartUploadRequest request) throws IOException, 
> OS3Exception {
>     if (!uploadID.equals("")) {
>       //Complete Multipart upload request.
>       return completeMultipartUpload(bucket, key, uploadID, request);
>     } else {
>       // Initiate Multipart upload request.
>       return initiateMultipartUpload(bucket, key);
>     }
>   }
> {code}
> Here we have a CompleteMultipartUploadRequest parameter which is created by 
> the JAXRS framework based on the media type and the request body. With 
> _Content-Type: application/xml_ it's easy: the JAXRS framework uses the 
> built-in JAXB serialization. But with plain/text content-type it's not 
> possible as there is no serialization support for 
> CompleteMultipartUploadRequest from plain/text.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to