[
https://issues.apache.org/jira/browse/HDDS-1222?focusedWorklogId=207897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207897
]
ASF GitHub Bot logged work on HDDS-1222:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/19 17:34
Start Date: 05/Mar/19 17:34
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #556: HDDS-1222. Remove
TestContainerSQLCli unit test stub
URL: https://github.com/apache/hadoop/pull/556#issuecomment-469776374
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 28 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 1179 | trunk passed |
| +1 | compile | 62 | trunk passed |
| +1 | checkstyle | 18 | trunk passed |
| +1 | mvnsite | 34 | trunk passed |
| +1 | shadedclient | 687 | branch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 45 | trunk passed |
| +1 | javadoc | 19 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 39 | the patch passed |
| +1 | compile | 23 | the patch passed |
| +1 | javac | 23 | the patch passed |
| +1 | checkstyle | 12 | the patch passed |
| +1 | mvnsite | 25 | the patch passed |
| -1 | whitespace | 0 | The patch has 75 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| -1 | whitespace | 1 | The patch 19849 line(s) with tabs. |
| +1 | shadedclient | 924 | patch has no errors when building and testing
our client artifacts. |
| +1 | findbugs | 49 | the patch passed |
| +1 | javadoc | 17 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 70 | tools in the patch passed. |
| +1 | asflicense | 26 | The patch does not generate ASF License warnings. |
| | | 3366 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-556/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/556 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 0d71e997478c 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 2576401 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| whitespace |
https://builds.apache.org/job/hadoop-multibranch/job/PR-556/1/artifact/out/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/hadoop-multibranch/job/PR-556/1/artifact/out/whitespace-tabs.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-556/1/testReport/ |
| Max. process+thread count | 2334 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/tools U: hadoop-ozone/tools |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-556/1/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 207897)
Time Spent: 0.5h (was: 20m)
> Remove TestContainerSQLCli unit test stub
> -----------------------------------------
>
> Key: HDDS-1222
> URL: https://issues.apache.org/jira/browse/HDDS-1222
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In HDDS-447 we removed the support the 'ozone noz' cli tool which was a
> rocksdb/leveldb to sql exporter.
> But still we have the unit test for the tool (in fact only the skeleton of
> the unit test, as the main logic is removed). Even worse this unit test is
> failing as it calls System.exit:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test (default-test)
> on project hadoop-ozone-tools: There are test failures.
> [ERROR]
> [ERROR] Please refer to
> /testptch/hadoop/hadoop-ozone/tools/target/surefire-reports for the
> individual test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> {code}
> I think this test can be deleted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
