[
https://issues.apache.org/jira/browse/HDDS-1210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784764#comment-16784764
]
Lokesh Jain edited comment on HDDS-1210 at 3/5/19 6:41 PM:
-----------------------------------------------------------
[~msingh] Thanks for working on this! The patch looks good to me. Sorry for the
late review. I have few minor comments.
# MockRatisPipelineProvider can extend RatisPipelineProvider. Then we would
only need to override the initializePipeline function.
# We can also place MockRatisPipelineProvider inside
org.apache.hadoop.hdds.scm.pipeline. Then we would not have to change the acess
modifier for PipelineStateManager and RatisPipelineProvider classes.
# Also should we send SCMPipelineManager instance inside the constructor
argument for pipeline factory? This would make sure that PipelineStateManager
and other classes are not exposed outside the pipeline package.
# There are a few checkstyle issues.
was (Author: ljain):
[~msingh] Thanks for working on this! The patch looks good to me. Sorry for the
late review. I have few minor comments.
# MockRatisPipelineProvider can extend RatisPipelineProvider. Then we would
only need to override the initializePipeline function.
# We can also place MockRatisPipelineProvider inside
org.apache.hadoop.hdds.scm.pipeline. Then we would not have to change the acess
modifier for PipelineStateManager and RatisPipelineProvider classes.
# Also should we send SCMPipelineManager instance inside the constructor
argument for pipeline factory? This would make sure that PipelineStateManager
and other classes are not exposed outside the pipeline package.
> Ratis pipeline creation doesn't check raft client reply status during
> initialization
> -------------------------------------------------------------------------------------
>
> Key: HDDS-1210
> URL: https://issues.apache.org/jira/browse/HDDS-1210
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: HDDS-1210.001.patch, HDDS-1210.002.patch,
> HDDS-1210.003.patch, HDDS-1210.004.patch, HDDS-1210.005.patch,
> HDDS-1210.006.patch
>
>
> Ratis pipeline are initialized using `raftClient.groupAdd`. However the
> pipeline initialization can fail and this can only be determined by
> raftClientReply status.
> {code}
> callRatisRpc(pipeline.getNodes(), ozoneConf,
> (raftClient, peer) -> raftClient.groupAdd(group, peer.getId()));
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
