[ https://issues.apache.org/jira/browse/HDDS-1175?focusedWorklogId=208241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208241 ]
ASF GitHub Bot logged work on HDDS-1175: ---------------------------------------- Author: ASF GitHub Bot Created on: 06/Mar/19 01:56 Start Date: 06/Mar/19 01:56 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #557: HDDS-1175. Serve read requests directly from RocksDB. URL: https://github.com/apache/hadoop/pull/557#issuecomment-469934900 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | 0 | reexec | 66 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 84 | Maven dependency ordering for branch | | +1 | mvninstall | 1257 | trunk passed | | -1 | compile | 568 | root in trunk failed. | | +1 | checkstyle | 198 | trunk passed | | -1 | mvnsite | 41 | common in trunk failed. | | -1 | mvnsite | 45 | integration-test in trunk failed. | | -1 | mvnsite | 26 | ozone-manager in trunk failed. | | +1 | shadedclient | 1103 | branch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | -1 | findbugs | 41 | common in trunk failed. | | -1 | findbugs | 29 | ozone-manager in trunk failed. | | +1 | javadoc | 128 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 65 | Maven dependency ordering for patch | | -1 | mvninstall | 29 | integration-test in the patch failed. | | -1 | compile | 605 | root in the patch failed. | | -1 | javac | 605 | root in the patch failed. | | +1 | checkstyle | 192 | the patch passed | | -1 | mvnsite | 32 | integration-test in the patch failed. | | -1 | whitespace | 1 | The patch has 75 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply | | -1 | whitespace | 1 | The patch 19849 line(s) with tabs. | | +1 | xml | 2 | The patch has no ill-formed XML file. | | +1 | shadedclient | 691 | patch has no errors when building and testing our client artifacts. | | 0 | findbugs | 0 | Skipped patched modules with no Java source: hadoop-ozone/integration-test | | +1 | findbugs | 233 | the patch passed | | +1 | javadoc | 45 | common in the patch passed. | | +1 | javadoc | 39 | common in the patch passed. | | +1 | javadoc | 18 | integration-test in the patch passed. | | +1 | javadoc | 24 | hadoop-ozone_ozone-manager generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) | ||| _ Other Tests _ | | -1 | unit | 87 | common in the patch failed. | | -1 | unit | 43 | common in the patch failed. | | -1 | unit | 36 | integration-test in the patch failed. | | +1 | unit | 49 | ozone-manager in the patch passed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 6313 | | | Reason | Tests | |-------:|:------| | Failed junit tests | hadoop.hdds.security.x509.certificate.client.TestDefaultCertificateClient | | | hadoop.ozone.security.TestOzoneDelegationTokenSecretManager | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/557 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml findbugs checkstyle | | uname | Linux 298573dbba86 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 7f636b4 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/branch-compile-root.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/branch-mvnsite-hadoop-ozone_common.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/branch-mvnsite-hadoop-ozone_integration-test.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/branch-mvnsite-hadoop-ozone_ozone-manager.txt | | findbugs | v3.1.0-RC1 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/branch-findbugs-hadoop-ozone_common.txt | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/branch-findbugs-hadoop-ozone_ozone-manager.txt | | mvninstall | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/patch-mvninstall-hadoop-ozone_integration-test.txt | | compile | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/patch-compile-root.txt | | javac | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/patch-compile-root.txt | | mvnsite | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/patch-mvnsite-hadoop-ozone_integration-test.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/whitespace-eol.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/whitespace-tabs.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/patch-unit-hadoop-hdds_common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/patch-unit-hadoop-ozone_common.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/artifact/out/patch-unit-hadoop-ozone_integration-test.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/testReport/ | | Max. process+thread count | 342 (vs. ulimit of 5500) | | modules | C: hadoop-hdds/common hadoop-ozone/common hadoop-ozone/integration-test hadoop-ozone/ozone-manager U: . | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-557/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 208241) Time Spent: 0.5h (was: 20m) > Serve read requests directly from RocksDB > ----------------------------------------- > > Key: HDDS-1175 > URL: https://issues.apache.org/jira/browse/HDDS-1175 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Components: Ozone Manager > Reporter: Hanisha Koneru > Assignee: Hanisha Koneru > Priority: Major > Labels: pull-request-available > Attachments: HDDS-1175.001.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > We can directly server read requests from the OM's RocksDB instead of going > through the Ratis server. OM should first check its role and only if it is > the leader can it server read requests. > There can be a scenario where an OM can lose its Leader status but not know > about the new election in the ring. This OM could server stale reads for the > duration of the heartbeat timeout but this should be acceptable (similar to > how Standby Namenode could possibly server stale reads till it figures out > the new status). -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org