[
https://issues.apache.org/jira/browse/HDDS-918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16789450#comment-16789450
]
Elek, Marton commented on HDDS-918:
-----------------------------------
Thanks the patch [~swagle]. Short-term I have no big problem with this, but
long-term it seems to be dangerous.
If I understood well with every reporting period a full scan on the container
list will be executed and a lock will be held during the scan. As this is a
scan on an in-memory datastructure it should be fast enough unless you have
millions of containers (which is possible). With using a lower number of metric
reporting period (eg. 5sec) it could be a problem.
It may be more effective to maintain counters in the ContainerAttribute class
and expose them in the hadoop metrics. (IMHO)
> Expose SCMMXBean
> ----------------
>
> Key: HDDS-918
> URL: https://issues.apache.org/jira/browse/HDDS-918
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Siddharth Wagle
> Priority: Major
> Labels: newbie
> Attachments: HDDS-918.01.patch, HDDS-918.02.patch, HDDS-918.03.patch,
> HDDS-918.04.patch
>
>
> Implement MetricsSource interface, so that external metrics can collect the
> SCMMXBean metrics information.
>
> From *MetricsSource.java:*
> It registers with \{@link MetricsSystem}, which periodically polls it to
> collect \{@link MetricsRecord} and passes it to \{@link MetricsSink}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
