[
https://issues.apache.org/jira/browse/HDFS-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790769#comment-16790769
]
Íñigo Goiri commented on HDFS-14351:
------------------------------------
Thanks [~hexiaoqiao] for the rebase.
I would extend the test to test both cases and a couple more:
* "ns1,nn0,ns1,nn1"
* "ns1,nn0, ns1,nn1"
* " ns1,nn0,ns1,nn1"
* "ns1,nn0,ns1,nn1 "
Here we can also clean the double initialization of the {{StringBuilder}} (this
was already there).
It might be worth adding a test just for this instead of going through the
whole TestRouterNamenodeMonitoring; up to you.
> RBF: Optimize configuration item resolving for monitor namenode
> ---------------------------------------------------------------
>
> Key: HDFS-14351
> URL: https://issues.apache.org/jira/browse/HDFS-14351
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: He Xiaoqiao
> Assignee: He Xiaoqiao
> Priority: Major
> Attachments: HDFS-14351-HDFS-13891.001.patch, HDFS-14351.001.patch,
> HDFS-14351.002.patch
>
>
> We invoke {{configuration.get}} to resolve configuration item
> `dfs.federation.router.monitor.namenode` at `Router.java`, then split the
> value by comma to get nsid and nnid, it may confused users since this is not
> compatible with blank space but other common parameters could do. The
> following segment show example that resolve fails.
> {code:java}
> <property>
> <name>dfs.federation.router.monitor.namenode</name>
> <value>nameservice1.nn1, nameservice1.nn2</value>
> <description>
> The identifier of the namenodes to monitor and heartbeat.
> </description>
> </property>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
