[
https://issues.apache.org/jira/browse/HDDS-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792154#comment-16792154
]
Bharat Viswanadham commented on HDDS-917:
-----------------------------------------
Hi [~swagle]
Thanks for your contribution.
Overall patch LGTM.
Few minor comments:
# Can we increase the Thread.sleep to a little large value? (So that on
Jenkins we don't see failures if this heartbeat is not processed, we will see
failures)
# Fix Jenkins reported white-space issues.
> Expose NodeManagerMXBean as a MetricsSource
> -------------------------------------------
>
> Key: HDDS-917
> URL: https://issues.apache.org/jira/browse/HDDS-917
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Siddharth Wagle
> Priority: Major
> Labels: newbie
> Attachments: HDDS-917.01.patch, HDDS-917.02.patch, HDDS-917.03.patch
>
>
> Implement MetricsSource interface, so that external metrics can collect the
> NodeManagerMXBean metrics information.
>
> From *MetricsSource.java:*
> It registers with \{@link MetricsSystem}, which periodically polls it to
> collect \{@link MetricsRecord} and passes it to \{@link MetricsSink}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
