[
https://issues.apache.org/jira/browse/HDFS-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792890#comment-16792890
]
CR Hota edited comment on HDFS-13972 at 3/14/19 5:25 PM:
---------------------------------------------------------
[~elgoiri]
Took a look at this now.
Mock values are fine. The assert has to be changed, its incorrectly checking >=
instead of a <= . Max date (typically 7 days) of a token will never change
irrespective of number of renewals. What changes is expiry date (which is
different than max date) if not renewed within a certain interval. Expiry date
should always be <= maxDate. The equals is needed because towards the end of
almost 7 days if client tries to renew a token expiry date will be send back as
the maxDate as after maxDate token becomes invalid and brand new token is
needed to continue as renewals wont work.
Will change it in here first for web and then in RPC through a separate ticket
to make sure we pass the context to users correctly of why the change is
needed.
was (Author: crh):
[~elgoiri]
Took a look at this now.
Mock values are fine. The assert has to be changed, its incorrectly checking >=
instead of a <= . Max date (typically 7 days) of a token will never change
irrespective of number of renewals. What changes is expiry date (which is
different than max date) if not renewed within a certain interval. Expiry date
should always be <= maxDate. The equals is needed because towards the end of
almost 7 days if client tries to renew a token expiry date will be send back as
the maxDate as after maxDate token becomes invalid and brand new token is
needed to continue as renewals wont work.
> RBF: Support for Delegation Token (WebHDFS)
> -------------------------------------------
>
> Key: HDFS-13972
> URL: https://issues.apache.org/jira/browse/HDFS-13972
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Íñigo Goiri
> Assignee: CR Hota
> Priority: Major
> Attachments: HDFS-13972-HDFS-13891.001.patch,
> HDFS-13972-HDFS-13891.002.patch, HDFS-13972-HDFS-13891.003.patch,
> HDFS-13972-HDFS-13891.004.patch, HDFS-13972-HDFS-13891.005.patch,
> HDFS-13972-HDFS-13891.006.patch, HDFS-13972-HDFS-13891.007.patch,
> TestRouterWebHDFSContractTokens.java
>
>
> HDFS Router should support issuing HDFS delegation tokens through WebHDFS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
