[
https://issues.apache.org/jira/browse/HDFS-14371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793134#comment-16793134
]
Siyao Meng commented on HDFS-14371:
-----------------------------------
In case of parameters being variables, that should be fine. But in case of
parameters being non-trivial function calls like metaSaveAsString(), which
involves string operations, it will be executed every time IMHO, removing the
debug check will likely lead to performance degradation. Especially when it's
called frequently.
> Improve Logging in FSNamesystem by adding parameterized logging
> ---------------------------------------------------------------
>
> Key: HDFS-14371
> URL: https://issues.apache.org/jira/browse/HDFS-14371
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs
> Affects Versions: 3.3.0
> Reporter: Shweta
> Assignee: Shweta
> Priority: Minor
> Attachments: HDFS-14371.001.patch
>
>
> Remove several instances of check for debug log enabled in FSNamesystem one
> such example is as:
> {code}
> if (LOG.isDebugEnabled()) {
> LOG.debug("NameNode metadata after re-processing " +
> "replication and invalidation queues during failover:\n" +
> metaSaveAsString());
> }
> {code}
> This can be replaced by using parameterized logging.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
