[
https://issues.apache.org/jira/browse/HDFS-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16794291#comment-16794291
]
Feilong He edited comment on HDFS-14355 at 3/16/19 3:28 PM:
------------------------------------------------------------
[~rakeshr], thanks so much for your review and comments!
# I have renamed the configs as you suggested.
# New way to get MappableBlockLoader instance is introduced to replace the
previous if-else check way, which can make new implementation for
MappableBlockLoader easily plugin in.
# The message has been supplemented with the specific property name.
# Unmap statement has been added in that piece of code.
# Yes, this assert statement is not necessary and has been removed.
# The path where block is mapped to has been described in the corresponding
function's javadoc.
# The annotation has been added for {{public static void
verifyIfValidPmemVolume(File pmemDir)}} function.
# The annotations has been added for two new classes.
# 1) the MLOCK config has been removed. 2) The test class has been moved into
the suggested package. Thus our previous change for FsDatasetImpl is
unnecessary.
I have uploaded a new patch. This patch can be directly applied on upstream
trunk branch. [~rakeshr], please feel free to post your comments if you have
more suggestions. Suggestions from other reviewers are also welcome.
was (Author: philohe):
[~rakeshr], thanks so much for your review and comments!
# I have renamed the configs as you suggested.
# New way to get MappableBlockLoader instance is introduced to replace the
previous if-else check way, which can make new implementation for
MappableBlockLoader easily plugin in.
# The message has been supplemented with the specific property name.
# Unmap statement has been added in that piece of code.
# Yes, this assert statement is not necessary and has been removed.
# The path where block is mapped to has been described in the corresponding
function's javadoc.
# The annotation has been added for {{public static void
verifyIfValidPmemVolume(File pmemDir)}} function.
# The annotations has been added for two new classes.
# 1) the MLOCK config has been removed. 2) The test class has been moved into
the suggested package. Thus our previous change for FsDatasetImpl is
unnecessary.
I have uploaded a new patch. This patch can be directly applied to upstream
trunk branch. [~rakeshr], please feel free to post your comments if you have
more suggestions. Suggestions from other reviewers are also welcome.
> Implement SCM cache using pure java mapped byte buffer
> ------------------------------------------------------
>
> Key: HDFS-14355
> URL: https://issues.apache.org/jira/browse/HDFS-14355
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching, datanode
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Attachments: HDFS-14355.000.patch, HDFS-14355.001.patch,
> HDFS-14355.002.patch
>
>
> This task is to implement the caching to persistent memory using pure
> {{java.nio.MappedByteBuffer}}, which could be useful in case native support
> isn't available or convenient in some environments or platforms.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
