[ 
https://issues.apache.org/jira/browse/HDDS-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795274#comment-16795274
 ] 

Hadoop QA commented on HDDS-1250:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
27s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
19s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 16m 
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
30s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 28s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
31s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
9s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green}  1m 
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
28s{color} | {color:green} the patch passed {color} |
| {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange}  
0m 20s{color} | {color:orange} hadoop-ozone: The patch generated 1 new + 0 
unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 23s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Skipped patched modules with no Java source: 
hadoop-ozone/integration-test {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
36s{color} | {color:green} common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
34s{color} | {color:green} ozone-manager in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 55s{color} 
| {color:red} integration-test in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
25s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 76m 11s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.ozone.TestStorageContainerManager |
|   | hadoop.ozone.scm.TestXceiverClientManager |
|   | hadoop.ozone.om.TestOmBlockVersioning |
|   | hadoop.ozone.om.TestContainerReportWithKeys |
|   | hadoop.ozone.TestContainerOperations |
|   | hadoop.hdds.scm.container.TestContainerStateManagerIntegration |
|   | hadoop.hdds.scm.pipeline.TestNode2PipelineMap |
|   | hadoop.ozone.client.rpc.TestContainerStateMachineFailures |
|   | hadoop.hdds.scm.pipeline.TestRatisPipelineUtils |
|   | hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey |
|   | hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics |
|   | 
hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler
 |
|   | 
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
 |
|   | hadoop.ozone.container.ozoneimpl.TestOzoneContainer |
|   | hadoop.ozone.web.client.TestVolume |
|   | hadoop.ozone.ozShell.TestOzoneShell |
|   | hadoop.ozone.ozShell.TestS3Shell |
|   | hadoop.ozone.web.client.TestBuckets |
|   | hadoop.ozone.ozShell.TestOzoneDatanodeShell |
|   | hadoop.ozone.web.TestOzoneRestWithMiniCluster |
|   | hadoop.ozone.TestMiniOzoneCluster |
|   | hadoop.ozone.scm.TestXceiverClientMetrics |
|   | hadoop.ozone.web.client.TestOzoneClient |
|   | hadoop.hdds.scm.pipeline.TestSCMRestart |
|   | hadoop.ozone.om.TestMultipleContainerReadWrite |
|   | 
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
 |
|   | hadoop.ozone.TestContainerStateMachineIdempotency |
|   | hadoop.ozone.client.rpc.TestBCSID |
|   | hadoop.ozone.om.TestOmMetrics |
|   | hadoop.ozone.scm.TestContainerSmallFile |
|   | hadoop.ozone.om.TestOzoneManagerConfiguration |
|   | hadoop.ozone.scm.TestSCMMXBean |
|   | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
|   | hadoop.ozone.om.TestOmAcls |
|   | hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean |
|   | hadoop.ozone.client.rpc.TestReadRetries |
|   | hadoop.ozone.om.TestOMDbCheckpointServlet |
|   | hadoop.ozone.client.rpc.TestOzoneRpcClient |
|   | hadoop.ozone.om.TestOzoneManager |
|   | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
|   | hadoop.hdds.scm.pipeline.TestPipelineClose |
|   | hadoop.ozone.web.TestOzoneVolumes |
|   | hadoop.ozone.om.TestOzoneManagerRestInterface |
|   | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
|   | hadoop.ozone.scm.TestAllocateContainer |
|   | hadoop.ozone.om.TestOzoneManagerHA |
|   | hadoop.ozone.om.TestOmInit |
|   | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode |
|   | hadoop.ozone.web.TestOzoneWebAccess |
|   | hadoop.ozone.container.TestContainerReplication |
|   | hadoop.ozone.om.TestScmChillMode |
|   | hadoop.ozone.scm.node.TestSCMNodeMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/15/artifact/out/Dockerfile
 |
| GITHUB PR | https://github.com/apache/hadoop/pull/591 |
| JIRA Issue | HDDS-1250 |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  cc  |
| uname | Linux f5a4a9444ed1 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 5446e3c |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| checkstyle | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/15/artifact/out/diff-checkstyle-hadoop-ozone.txt
 |
| unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/15/artifact/out/patch-unit-hadoop-ozone_integration-test.txt
 |
|  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/15/testReport/ |
| Max. process+thread count | 2928 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager 
hadoop-ozone/integration-test U: hadoop-ozone |
| Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-591/15/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |


This message was automatically generated.



> In OM HA AllocateBlock call where connecting to SCM from OM should not happen 
> on Ratis
> --------------------------------------------------------------------------------------
>
>                 Key: HDDS-1250
>                 URL: https://issues.apache.org/jira/browse/HDDS-1250
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>            Reporter: Bharat Viswanadham
>            Assignee: Bharat Viswanadham
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 50m
>  Remaining Estimate: 0h
>
> In OM HA, currently when allocateBlock is called, in applyTransaction() on 
> all OM nodes, we make a call to SCM and write the allocateBlock information 
> into OM DB. The problem with this is, every OM allocateBlock and appends new 
> BlockInfo into OMKeyInfom and also this a correctness issue. (As all OM's 
> should have the same block information for a key, even though eventually this 
> might be changed during key commit)
>  
> The proposed approach is:
> 1. Calling SCM for allocation of block will happen outside of ratis, and this 
> block information is passed and writing to DB will happen via Ratis.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to